dockerfile: additional expansions #1241
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
+ Coverage 55.76% 56.30% +0.53%
==========================================
Files 265 265
Lines 16562 16675 +113
==========================================
+ Hits 9236 9389 +153
+ Misses 6365 6323 -42
- Partials 961 963 +2 ☔ View full report in Codecov by Sentry. |
hdonnay
force-pushed
the
bug/dockerfile-expansions
branch
from
550e102 to
4b42bfd
Compare
|
I've run this through the fuzzer for a while, with no crashers being reported. |
hdonnay
force-pushed
the
bug/dockerfile-expansions
branch
from
4b42bfd to
c325e4a
Compare
hdonnay
force-pushed
the
bug/dockerfile-expansions
branch
from
c325e4a to
97268e9
Compare
This makes things much simpler, IMO. Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
hdonnay
force-pushed
the
bug/dockerfile-expansions
branch
from
97268e9 to
29d187a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw some errors on quayio's instance related to variable expansions.
Checking the buildkit dockerfile frontend, it supports the whole compliment of POSIX expansions and bash-style replace (
${var/pat/word/}).This PR implements all the POSIX expansions and reports a dedicated error for the slash pattern replacement.
Dockerfile